Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some useful cache middlewares for client (i.e browser) catching #934

Merged
merged 2 commits into from
Mar 17, 2018

Conversation

speedwheel
Copy link
Contributor

New:

  • cache.StaticCache (and iris.StaticCache shortcut like the rest)

Re-write but keep compatibility with the server-side no-catching:

  • cache.NoCache (and iris.NoCache shortcut like the rest)

Tests:

  • kataras/iris/cache/browser_test.go for StaticCache, NoCache and Cache304

Code Guidelines of the Iris project are followed.

Branch: dev , push to master whenever you release the next version @kataras.

@kataras
Copy link
Owner

kataras commented Mar 17, 2018

That's wonderful @speedwheel, small but complete, you've faithfully followed the Iris' comments structure and testing, that's a prototype PR that other future contributors need to look as well. Excellent job.

@kataras kataras merged commit 252a8b6 into kataras:dev Mar 17, 2018
github-actions bot pushed a commit to goproxies/github.com-kataras-iris that referenced this pull request Jul 27, 2020
By @speedwheel via PR kataras#934

Former-commit-id: 653815c2ef09039ee2a867ec1d95d984997a179a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants