Fixes Deprecation Warnings for SimpleForm ~> 3.1 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't think the Travis CI error is related to my code changes but I will see if I can reproduce on my local and possible fix it up. |
mdeering
added a commit
to mdeering/textile_editor_helper
that referenced
this pull request
Aug 11, 2015
Why: * "rake test" portion of the build is broken * https://travis-ci.org/katgironpe/textile_editor_helper/builds/75128504 This change addresses the need by: * Get pull request I have submitted passing. Pull request is failing due to these issue and not any real issues with the code. kathgironpe#7
|
Pull request #8 submitted separately that will fix the build here. |
kathgironpe
added a commit
that referenced
this pull request
Aug 12, 2015
Fixes Deprecation Warnings for SimpleForm ~> 3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background from simple_form heartcombo/simple_form#997