Feat: add error event #3532
Merged
Feat: add error event #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katspaugh
reviewed
Jan 29, 2024
katspaugh
reviewed
Jan 29, 2024
|
One of the tests seems to be failing on this branch. |
katspaugh
added a commit
that referenced
this pull request
Mar 9, 2024
katspaugh
added a commit
that referenced
this pull request
Mar 9, 2024
* Refactor: re-throw error on load * Media event type * Rm the blob check added in #3532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Adds support for
wavesurfer.on('error')event. This is helpful when building components where the file source is unknown at build time and you might want to hook into that event to display an error message.Implementation details
It catches errors thrown by "Fetcher.fetchBlob" and emits it as an event named
errorHow to test it
Screenshots
Checklist
I think it's likely that this introduces a breaking API change if users previously relied on
.createthrowing an exception which is now caught and reported by.on('error').