Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Split channel overflowing when height:auto #3705

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

htc36
Copy link
Contributor

@htc36 htc36 commented May 14, 2024

Short description

Resolves #3690

Implementation details

Alter getHeight function to divide the parentHeight by number of channels if the height=auto of the wavesurfer instance

How to test it

  • Give the parent container a height
  • Set height : auto & splitChannel : [] of Wavesurfer instance
  • Observe the waveforms not overflowing outside the parent container as their heights are

Screenshots (Observe split channels is half the size of the parent)

splitChannel=[] splitChannel=undefined
image image

Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@katspaugh katspaugh merged commit 290202f into katspaugh:main May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants