Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ops): #18 use commitizen #21

Merged
merged 5 commits into from
Mar 13, 2024
Merged

feat(ops): #18 use commitizen #21

merged 5 commits into from
Mar 13, 2024

Conversation

cmp0xff
Copy link
Collaborator

@cmp0xff cmp0xff commented Mar 12, 2024

No description provided.

cmp0xff and others added 4 commits March 10, 2024 22:51
@cmp0xff
feat: use commitizen (#19)
e3cfd56 
* feat(commitizen): #18 add commitizen to dependencies

* doc(README): #18 describe publish process
@cmp0xff
feat(commitizen): changelog path
11e2429
@cmp0xff
doc(commitizen): #18 update instruction
32181ea
@cmp0xff
chore(poetry): #18 🔒
8d473cd
@cmp0xff cmp0xff added the enhancement New feature or request label Mar 12, 2024
@cmp0xff cmp0xff requested a review from emptymalei March 12, 2024 19:50
@cmp0xff cmp0xff self-assigned this Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

✅ Result of Pytest Coverage

---------- coverage: platform darwin, python 3.12.2-final-0 ----------

Name Stmts Miss Cover
hamilflow/init.py 0 0 100%
hamilflow/models/init.py 0 0 100%
hamilflow/models/harmonic_oscillator.py 65 3 95%
TOTAL 65 3 95%
========================= 7 passed, 1

emptymalei
emptymalei reviewed Mar 12, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
emptymalei
emptymalei reviewed Mar 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
@emptymalei
Copy link
Member

emptymalei commented Mar 12, 2024 •
edited
Loading

I just approved it. I feel this workflow is not using the full potential of GitHub (e.g., the release branch thing). But let's get this part done and move on.

@cmp0xff cmp0xff merged commit b34fe41 into main Mar 13, 2024
16 checks passed
@cmp0xff cmp0xff deleted the feature/18-use-commitizen branch March 13, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emptymalei emptymalei emptymalei approved these changes

Assignees

@cmp0xff cmp0xff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmp0xff @emptymalei