Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model): add brownian motion #23

Merged
merged 16 commits into from
Mar 21, 2024
Merged

feat(model): add brownian motion #23

merged 16 commits into from
Mar 21, 2024

Conversation

emptymalei
Copy link
Member

@emptymalei emptymalei commented Mar 14, 2024 •
edited by cmp0xff
Loading

Resolves #17

Added

  • Brownian motion
    • Added package scipy
    • Added module brownian_motion.py
    • Added tests
  • Tutorial of Brownian motion
  • PR Review @cmp0xff / @kausalflow/dynamical-systems
  • add changelog @emptymalei
  • bump version @emptymalei

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited
Loading

✅ Result of Pytest Coverage

---------- coverage: platform darwin, python 3.12.2-final-0 ----------

Name Stmts Miss Cover
hamilflow/init.py 0 0 100%
hamilflow/models/init.py 0 0 100%
hamilflow/models/brownian_motion.py 41 1 98%
hamilflow/models/harmonic_oscillator.py 65 3 95%
TOTAL 106 4 96%
======================== 17 passed, 1

@emptymalei emptymalei changed the title Feature: Brownian Motion feature/Brownian Motion Mar 15, 2024
@emptymalei emptymalei changed the title feature/Brownian Motion feature/brownian-motion Mar 15, 2024
@cmp0xff cmp0xff added the enhancement New feature or request label Mar 15, 2024
@emptymalei emptymalei added documentation Improvements or additions to documentation model Change of models labels Mar 15, 2024
@emptymalei emptymalei marked this pull request as ready for review March 15, 2024 22:30
@emptymalei emptymalei requested a review from cmp0xff March 15, 2024 22:30
@emptymalei emptymalei mentioned this pull request Mar 15, 2024
Closed
cmp0xff
cmp0xff reviewed Mar 16, 2024
View reviewed changes
hamilflow/models/brownian_motion.py Outdated Show resolved Hide resolved
hamilflow/models/brownian_motion.py Show resolved Hide resolved
hamilflow/models/brownian_motion.py Show resolved Hide resolved
hamilflow/models/brownian_motion.py Show resolved Hide resolved
hamilflow/models/brownian_motion.py Outdated Show resolved Hide resolved
hamilflow/models/brownian_motion.py Show resolved Hide resolved
@cmp0xff
Copy link
Collaborator

cmp0xff commented Mar 17, 2024

I did not intend to check the code from a physical perspective. From a programming point of view, the PR is good to go.

@emptymalei
Copy link
Member Author

I did not intend to check the code from a physical perspective. From a programming point of view, the PR is good to go.

No rush. We can wait. Let's also double check the physics.

cmp0xff
cmp0xff approved these changes Mar 17, 2024
View reviewed changes
docs/tutorials/brownian_motion.py Outdated Show resolved Hide resolved
hamilflow/models/brownian_motion.py Outdated Show resolved Hide resolved
hamilflow/models/brownian_motion.py Outdated Show resolved Hide resolved
docs/tutorials/brownian_motion.py Outdated Show resolved Hide resolved
@netlify Netlify

This comment was marked as outdated.

Sign in to view
@emptymalei emptymalei changed the title feature/brownian-motion feat(model): brownian motion Mar 18, 2024
@emptymalei emptymalei changed the title feat(model): brownian motion feat(model): add brownian motion Mar 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

Coverage

Coverage Report (485f298, 3.12, macos-latest)
FileStmtsMissCoverMissing
hamilflow
   __init__.py00100% 
hamilflow/models
   __init__.py00100% 
   brownian_motion.py4111 98%
   harmonic_oscillator.py6533 95%
TOTAL106496% 

Tests Skipped Failures Errors Time
17 0 💤 0 ❌ 0 🔥 32.969s ⏱️

@emptymalei emptymalei merged commit 7327a4d into main Mar 21, 2024
8 checks passed
@emptymalei emptymalei deleted the feature/brownian-motion branch March 21, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmp0xff cmp0xff cmp0xff approved these changes

Assignees

@emptymalei emptymalei

Labels
documentation Improvements or additions to documentation enhancement New feature or request model Change of models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brownian motion
2 participants
@emptymalei @cmp0xff