Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model harmonic oscillator configuration space #8

Merged
merged 14 commits into from
Mar 2, 2024

Conversation

emptymalei
Copy link
Member

@emptymalei emptymalei commented Feb 19, 2024

#9

To do

To be discussed

  • Better ways of dealing with the time dimension?

Added

  • simple/overdamped/criticaldamped/underdamped harmonic oscillator in configuration space
  • tests for the four HO scenarios
  • docs for HO 127 0 0 1_8000_hamiltonian_flow_references_models_harmonic_oscillator_ (1)

@emptymalei emptymalei changed the title WIP: Model harmonic oscillator conf WIP: Model harmonic oscillator configuration space Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

✅ Result of Pytest Coverage

---------- coverage: platform darwin, python 3.12.2-final-0 ----------

Name Stmts Miss Cover
hamiltonian_flow/init.py 0 0 100%
hamiltonian_flow/models/init.py 0 0 100%
hamiltonian_flow/models/harmonic_oscillator.py 65 3 95%
TOTAL 65 3 95%
======================== 7 passed, 2

@emptymalei emptymalei marked this pull request as ready for review February 20, 2024 08:49
@emptymalei
Copy link
Member Author

@cmp0xff our first model is here.

@emptymalei emptymalei changed the title WIP: Model harmonic oscillator configuration space Model harmonic oscillator configuration space Feb 20, 2024
@cmp0xff cmp0xff added the enhancement New feature or request label Feb 24, 2024
Copy link
Collaborator

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially reviewed...

Copy link
Collaborator

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we add a short example for this, in the style of a Jupyter Notebook. Then we can conclude this first system!

We can also use Jupyter Interactive of VSCode, so that we only keep .py scripts in the repo, but users can parse them with VSCode, and we do not accidentally upload ipynb with base64 data in them to the repo... It would also be easier for me to study and follow.

update: I did not see the tutorial in the next PR when I wrote this..

@emptymalei emptymalei merged commit b60fe4c into main Mar 2, 2024
16 checks passed
@emptymalei emptymalei deleted the model-harmonic-oscillator-conf branch March 2, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants