Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix right drawer placement on iPads #28

Merged
merged 1 commit into from
May 27, 2018
Merged

Fix right drawer placement on iPads #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions DrawerController/Models/DrawerContent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,16 +183,17 @@ public class DrawerContent {
contentView.frame.size.width = width
drawerOffset = 0.0

guard let superView = contentView.superview else { return }
guard let superview = contentView.superview else { return }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor case change

if drawerSide == .right {
drawerOffset = superView.frame.width - width
drawerOffset = superview.frame.width - width
}
viewController.view.frame = CGRect(
contentView.frame = CGRect(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we just adjust contentView.frame instead.

x: CGFloat(-drawerOffset),
y: 0,
width: width,
height: superView.frame.height
height: superview.frame.height
)
viewController.view.frame = contentView.bounds
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The viewController.view should just match its superview's (contentView) bounds.

}


Expand Down