Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override/fill requestOptions variable in _handleTicket #12

Open
M3lkior opened this issue Dec 2, 2016 · 0 comments
Open

Allow to override/fill requestOptions variable in _handleTicket #12

M3lkior opened this issue Dec 2, 2016 · 0 comments
Assignees

Comments

@M3lkior
Copy link

M3lkior commented Dec 2, 2016

Hello @kylepixel,

First, thanks for your library, it works like a charme, great job !

I use your library behind a corporate proxy but unfortunately, node.js http agent don't support corporate proxy and so, is unable to resolve my DNS to contact my CAS server :

Request error with CAS:  { Error: getaddrinfo ENOTFOUND cas.mydns.com cas.mydns.com:443
    at errnoException (dns.js:28:10)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:76:26)
  code: 'ENOTFOUND',
  errno: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: 'cas.mydns.com',
  host: 'cas.mydns.com',
  port: 443 }

So, to workaround this problem, i'm using https://github.com/TooTallNate/node-https-proxy-agent which allows to define corporate proxy in http.request.agent property :

...
requestOptions.agent = new HttpsProxyAgent('http://proxy.mycompany.com:80');

It's a blocking issue for me, if i do a pull request to allow developpers passing additionals properties to http.request options; could you validate it ?

Thanks !

M3lkior added a commit to M3lkior/cas-authentication that referenced this issue Dec 2, 2016
@kayleecodes1 kayleecodes1 self-assigned this Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants