Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test build failures in #150 #152

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Fix test build failures in #150 #152

merged 1 commit into from
Mar 16, 2020

Conversation

felixonmars
Copy link
Contributor

No description provided.

@felixonmars felixonmars mentioned this pull request Mar 1, 2020
Open
@kazu-yamamoto
Copy link
Owner

I think that we don't have to support very old network. Should we add version-boundary to dns.cabal?

@kazu-yamamoto kazu-yamamoto self-requested a review March 16, 2020 03:32
kazu-yamamoto
kazu-yamamoto approved these changes Mar 16, 2020
View reviewed changes
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some people still use old network. This patch introduces a warning but it's worth merging. Let's remove this code and the warning someday when the old network disappears.

@kazu-yamamoto kazu-yamamoto merged commit d8b1c2f into kazu-yamamoto:master Mar 16, 2020
@kazu-yamamoto
Copy link
Owner

Merged. Thank you for your contribution.
If you want to get a new version released, please let me know.

@felixonmars felixonmars deleted the patch-1 branch March 16, 2020 03:44
@felixonmars
Copy link
Contributor Author

It's fine for now since we already applied the patch, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixonmars @kazu-yamamoto