Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datetime): support all key format object (kazupon#1571) #1572

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix(datetime): support all key format object (kazupon#1571) #1572

merged 1 commit into from
Oct 31, 2022

Conversation

majdkhasib
Copy link
Contributor

No description provided.

@majdkhasib
Copy link
Contributor Author

@kazupon Can you take a look and review?

@majdkhasib majdkhasib mentioned this pull request Oct 31, 2022
Closed
5 tasks
@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Oct 31, 2022
kazupon
kazupon approved these changes Oct 31, 2022
View reviewed changes
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazupon kazupon merged commit 5ef6dc3 into kazupon:v8.x Oct 31, 2022
@pr-triage pr-triage bot added the PR: merged label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
PR: merged PR: reviewed-approved PR: unreviewed Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majdkhasib @kazupon