-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading text analysis from WS and displaying long-running tasks #512
Loading text analysis from WS and displaying long-running tasks #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, otherwise looks good (not tested, yet).
const minutes = padStart(date.getUTCMinutes().toString(), 2, "0"); | ||
const seconds = padStart(date.getUTCSeconds().toString(), 2, "0"); | ||
|
||
return <>{`${hours}${minutes}:${seconds}`}</>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using TimeAgo to display the duration of the task? We already use for displaying time since last edit/comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to show how long the task has been running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
see kbss-cvut/termit#295