Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading text analysis from WS and displaying long-running tasks #512

Merged

Conversation

lukaskabc
Copy link
Collaborator

Copy link
Contributor

@ledsoft ledsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, otherwise looks good (not tested, yet).

const minutes = padStart(date.getUTCMinutes().toString(), 2, "0");
const seconds = padStart(date.getUTCSeconds().toString(), 2, "0");

return <>{`${hours}${minutes}:${seconds}`}</>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using TimeAgo to display the duration of the task? We already use for displaying time since last edit/comment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to show how long the task has been running.

src/component/term/TermDetail.tsx Outdated Show resolved Hide resolved
src/component/vocabulary/VocabularySummary.tsx Outdated Show resolved Hide resolved
src/i18n/cs.ts Outdated Show resolved Hide resolved
src/i18n/en.ts Outdated Show resolved Hide resolved
src/reducer/WebSocketUtilityDispatchers.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ledsoft ledsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@ledsoft ledsoft merged commit 133ca25 into kbss-cvut:development Sep 13, 2024
6 checks passed
ledsoft pushed a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants