Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: output from verify-contextual-logging.sh is logically reversed #2537

Closed
MikeSpreitzer opened this issue Jan 3, 2023 · 0 comments · Fixed by #2577
Closed

bug: output from verify-contextual-logging.sh is logically reversed #2537

MikeSpreitzer opened this issue Jan 3, 2023 · 0 comments · Fixed by #2577
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@MikeSpreitzer
Copy link
Contributor

Describe the bug

When verify-contextual-logging.sh reports a change in the contextual logging output, it uses diff output but in the reverse of the order that is most intuitive. One would expect, as for example git diff does, to see a diff from the old to the new. But instead verify-contextual-logging.sh outputs a diff from the new to the old.

Steps To Reproduce

Look at any report, or the script itself.

Expected Behaviour

I expected a reported diff to be from the old to the new.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant