Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 verify-contextual-logging should diff from old to new #2577

Merged
merged 1 commit into from
Jan 10, 2023
Merged

🌱 verify-contextual-logging should diff from old to new #2577

merged 1 commit into from
Jan 10, 2023

Conversation

vincepri
Copy link
Contributor

Signed-off-by: Vince Prignano [email protected]

Summary

Related issue(s)

Fixes #2537

@sttts
Copy link
Member

sttts commented Jan 10, 2023

/retest
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit fd6cb5f into kcp-dev:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: output from verify-contextual-logging.sh is logically reversed
3 participants