🌱 remove deprecated home workspaces fields, add waiting for unmanaged servers in e2e #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
force-pushed
the
fix-e2e-kcp-servers
branch
from
4c36dff
to
650772a
Compare
|
Flake #2713 |
|
Flake #2714 |
|
#2713 again |
|
Flake #2685 |
sttts
reviewed
Jan 31, 2023
sttts
reviewed
Jan 31, 2023
ncdc
force-pushed
the
fix-e2e-kcp-servers
branch
2 times, most recently
from
80dbf00
to
ba30ed8
Compare
sttts
reviewed
Feb 1, 2023
sttts
reviewed
Feb 1, 2023
ncdc
force-pushed
the
fix-e2e-kcp-servers
branch
from
ba30ed8
to
c743528
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
kcp-dev/contrib-tmc#58 |
|
Most recent failure is because the RBAC needed for maximal permission policy didn't replicate "fast enough" to the cache server. Working on a commit to fix the e2e to use Eventually for this. |
Signed-off-by: Andy Goldstein <[email protected]>
Make both managed and unmanaged kcp servers wait for readiness. Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
Have to wrap creating the cowboy (via APIBinding) in an Eventually because the RBAC for the maximal permission policy may not replicate to the cache server "fast enough". Signed-off-by: Andy Goldstein <[email protected]>
ncdc
force-pushed
the
fix-e2e-kcp-servers
branch
from
c743528
to
8db9070
Compare
|
/lgtm |
openshift-ci
bot
added
lgtm
ncdc
force-pushed
the
fix-e2e-kcp-servers
branch
from
06e88c6
to
92f286a
Compare
Wrap verifying service-provider-2-admin is denied access to shadowed cowboys in an Eventually. Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
ncdc
force-pushed
the
fix-e2e-kcp-servers
branch
from
60ac84d
to
0b403cb
Compare
|
/retest |
|
/lgtm |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Can split into separate PRs if desired