Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Trying to fix doc generation #2717

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Jan 31, 2023

No description provided.

Signed-off-by: Andy Goldstein <[email protected]>
@ncdc ncdc requested review from avinal and removed request for csams and stevekuznetsov January 31, 2023 17:37
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

run: |
if ls docs/v* >/dev/null; then
rsync -av docs/v* public
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an else branch as well, printing "No such folder"? will be easier to track in logs. (probably an overkill)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@ncdc
Copy link
Member Author

ncdc commented Feb 1, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@ncdc
Copy link
Member Author

ncdc commented Feb 1, 2023

Flake #2713, which should be resolved now. Hopefully another retest will get past that.
/retest

@openshift-merge-robot openshift-merge-robot merged commit 669dd8d into kcp-dev:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants