Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ WIP: add network policy blocking cross-tenant pod traffic #2876

Closed
wants to merge 6 commits into from

Conversation

lionelvillard
Copy link
Contributor

@lionelvillard lionelvillard commented Mar 7, 2023

Summary

Create a network policy per namespace to prevent traffic between pods belonging to different tenant.

See https://github.com/kcp-dev/kcp/blob/3a5f114b6de2a033dcafe8d7d282d456ce5a70ea/pkg/syncer/spec/networkpolicy_tenant.yaml for more details.

Related issue(s)

Fixes kcp-dev/contrib-tmc#113

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2023
@lionelvillard lionelvillard marked this pull request as ready for review March 8, 2023 19:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2023
@ncdc ncdc added the area/transparent-multi-cluster Related to scheduling of workloads into pclusters. label Mar 14, 2023
@davidfestal
Copy link
Member

@lionelvillard Should I wait for e2e tests to be fixed before reviewing ?

@lionelvillard
Copy link
Contributor Author

@davidfestal If you want you can start looking at the network policy template while I'm fixing the e2e tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stevekuznetsov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@lionelvillard: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test 7df374c link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 23, 2023
@mjudeikis
Copy link
Contributor

/close
TMC

@kcp-ci-bot kcp-ci-bot closed this Mar 25, 2024
@kcp-ci-bot
Copy link
Contributor

@mjudeikis: Closed this PR.

In response to this:

/close
TMC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transparent-multi-cluster Related to scheduling of workloads into pclusters. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement workspace-based isolation of downstream namespaces through NetworkPolicies
6 participants