🐛 Inject kcp-start-informers logger into correct hook context
#3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server context Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
release-note-none
|
Skipping CI for Draft Pull Request. |
kcp-ci-bot
added
the
size/M
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
|
/cc @mjudeikis @xrstf |
kcp-ci-bot
added
release-note
|
LGTM label has been added. Git tree hash: 905c156049115f6b32ecd76717bb1179533b238c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/kind bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've observed log lines like the one below for quite a while:
{"ts":1715849616335.2378,"caller":"replication/replication_reconcile.go:200","msg":"Updating object in global cache","component":"kcp","postStartHook":"kcp-start-informers","postStartHook":"kcp-start-controllers","reconciler":"kcp-replication-controller","key":"v1.clusterroles.rbac.authorization.k8s.io::root|system:kcp:universal-workspacetype-use","reconcilerKey":"root|system:kcp:universal-workspacetype-use","kind":"ClusterRole","namespace":"","name":"system:kcp:universal-workspacetype-use","v":2}Note the double entry
"postStartHook":"kcp-start-informers","postStartHook":"kcp-start-controllers".Turns out that in the
kcp-start-informerspost start hook the logger gets injected intoctx. That's however not the context of the hook, it's the main context used by the whole(s *Server) Runmethod! This PR creates a newhookCtxthat is explicitly instantiated within the hook and is subsequently passed to all informers and the server bootstrap code.Note this is relatively low priority and I don't want it to block #3132.
Related issue(s)
Fixes #
Release Notes