Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix race issues in leader relection #3139

Merged
merged 1 commit into from
Jul 16, 2024
Merged

🐛 Fix race issues in leader relection #3139

merged 1 commit into from
Jul 16, 2024

Conversation

ramramu3433
Copy link

@ramramu3433 ramramu3433 commented Jun 10, 2024 •
edited
Loading

Summary

When the controller startup sequence is fixed with #3132 , there is a race condition introduced which would throw panic as the controller reintialization adds indexer to running informers

Related issue(s)

Fixes #

Release Notes

Calls intialize indexer only once before the informer starts

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates the PR's author has not signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2024
@kcp-ci-bot
Copy link
Contributor

Hi @ramramu3433. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 10, 2024
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 10, 2024
embik
embik requested changes Jun 10, 2024
View reviewed changes
pkg/server/controllers.go Outdated Show resolved Hide resolved
@kcp-ci-bot kcp-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2024
@ramramu3433 ramramu3433 requested a review from embik June 25, 2024 16:36
@ramramu3433
Copy link
Author

/ok-to-test

@kcp-ci-bot
Copy link
Contributor

@ramramu3433: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2024
@ramramu3433 ramramu3433 force-pushed the jr/fix-leader-election branch 2 times, most recently from cd7c997 to 02c2045 Compare June 26, 2024 06:38
embik
embik requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! One nit about the comments, apart from that it is looking good to me now.

pkg/permissionclaim/permissionclaim_labeler.go Outdated Show resolved Hide resolved
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 26, 2024
@ramramu3433
Copy link
Author

/ok-to-test

@ramramu3433 ramramu3433 requested a review from embik June 26, 2024 09:58
embik
embik requested changes Jun 28, 2024
View reviewed changes
pkg/server/controllers.go Show resolved Hide resolved
embik
embik approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: db2dd0520340aefca155db22e753c88547bcdceb

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@kcp-ci-bot kcp-ci-bot merged commit 45524db into kcp-dev:main Jul 16, 2024
16 checks passed
@embik embik mentioned this pull request Jul 29, 2024
Merged
@embik
Copy link
Member

embik commented Aug 27, 2024

/kind bug

@kcp-ci-bot kcp-ci-bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ramramu3433 @kcp-ci-bot @palnabarun @embik @janakiramanmesh7