🌱 Remove cmd/kcp-core binary
#3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
removed
the
needs-rebase
|
/retest |
|
/lgtm |
|
LGTM label has been added. Git tree hash: c20124f4d12579a02316297b49d134d8dbeff524
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/kind cleanup |
kcp-ci-bot
added
the
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2795 introduced
cmd/kcp-coreas a means to differentiate between the "core" extended apiserver and the core+tmc features (called "kcp"). However, when the project moved to community governance, "kcp" itself became the designated name for the "core" component and tmc moved to an external repository.I'd propose we remove
kcp-core, since it never served its intended purpose and probably won't either (if we ever revive transparent multi-cluster, I suspect we'll be naming the binary/projecttmc).Related issue(s)
Fixes #
Release Notes