Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix APIExport SSA apply configuration client #3153

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

sttts
Copy link
Member

@sttts sttts commented Aug 16, 2024

Summary

The JSON tag for the permission claim GroupResource embedded struct was wrong. The apply configuration resulted in an object like the following:

{
    "apiVersion": "apis.kcp.io/v1alpha1",
    "kind": "APIExport",
    "metadata":
    {
        "name": "fabrics.upbound.io"
    },
    "spec":
    {
        "latestResourceSchemas":
        [
            "v240816-2328.projects.fabrics.upbound.io",
            "v240816-2328.services.fabrics.upbound.io",
            "v240816-2328.servicetiers.fabrics.upbound.io",
            "v240816-2328.spaces.fabrics.upbound.io"
        ],
        "permissionClaims":
        [
            {
                "GroupResource":
                {
                    "group": "tenancy.kcp.io",
                    "resource": "workspaces"
                },
                "all": true,
                "identityHash": "1422105e93411affc2d91b197e07d9168c1e7ca3b01fc6955b393122be112491"
            }
        ]
    }
}

Related issue(s)

Fixes #

Release Notes

Fix apply configuration client for APIExport.

Signed-off-by: Dr. Stefan Schimanski <[email protected]>
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2024
@sttts
Copy link
Member Author

sttts commented Aug 16, 2024

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2024
@embik
Copy link
Member

embik commented Aug 17, 2024

/retest

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f20fcf878592504476f3d37764a851eca1d07581

@kcp-ci-bot kcp-ci-bot merged commit 909ded4 into kcp-dev:main Aug 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants