Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add kubectl-create-workspace command supported with latest kubectl #3154

Merged
merged 6 commits into from
Aug 17, 2024

Conversation

sttts
Copy link
Member

@sttts sttts commented Aug 17, 2024

Summary

With kubernetes/kubernetes#124123, kubectl supports create plugins. This PR adds create workspace.

Related issue(s)

Release Notes

Add `kubectl create workspace` plugin.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2024
@sttts sttts force-pushed the sttts-create-workspace-plugin branch 5 times, most recently from 46f3a99 to abe8c44 Compare August 17, 2024 13:01
@sttts
Copy link
Member Author

sttts commented Aug 17, 2024

/retest

@sttts sttts requested review from mjudeikis and embik August 17, 2024 13:21
@sttts sttts force-pushed the sttts-create-workspace-plugin branch 2 times, most recently from 2a47f40 to 89ae53b Compare August 17, 2024 13:56
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 339282f896479bf2ee17f62cb4032f1696f108cd

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 17, 2024
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
@sttts sttts force-pushed the sttts-create-workspace-plugin branch from 2e73395 to 2f6be82 Compare August 17, 2024 14:10
@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2024
@mjudeikis mjudeikis removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2024
@mjudeikis
Copy link
Contributor

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 91b7e5c8265da5369431ac3155fa4356830eccb1

@sttts sttts force-pushed the sttts-create-workspace-plugin branch from 0f7d463 to 4511369 Compare August 17, 2024 14:27
@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2024
@sttts
Copy link
Member Author

sttts commented Aug 17, 2024

/retest

@mjudeikis
Copy link
Contributor

/lgtm
try 3

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f9decb7984dea717ad47387204f39284da86009

@kcp-ci-bot kcp-ci-bot merged commit 9d45e6d into kcp-dev:main Aug 17, 2024
19 checks passed
@embik
Copy link
Member

embik commented Aug 27, 2024

/kind feature

@kcp-ci-bot kcp-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants