Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GMT-109: Snowflake writer supporting GCP #3

Merged
merged 30 commits into from
Mar 14, 2024
Merged

GMT-109: Snowflake writer supporting GCP #3

merged 30 commits into from
Mar 14, 2024

Conversation

romantmb
Copy link
Contributor

@romantmb romantmb commented Mar 7, 2024

@romantmb romantmb requested a review from ondrajodas March 7, 2024 10:08
@romantmb
Remove foreign-key func. tests (as multiple tables nor foreign keys a…
c065a7b 
…re no longer supported)
@romantmb
- fix copying of .csv in tests
d2561ed 
- add missing SKIP_HEADER = 1 in COPY INTO query
@romantmb
Update tests (vol. 2)
a693e5d
@romantmb
Replace empty strings and 'NULL's with null in COPY INTO query
cc99437
@romantmb
Update tests (vol. 3, all good)
9470717
@romantmb
Cleanup unused write strategy
f28f36a
@romantmb
Set stopOnFailure="false" in phpunit.xml.dist
2de154b
@romantmb
Fix workflows/push.yml (dockerhub user)
ff25f1e
@romantmb
Update workflows/push.yml (app image & dev portal ID)
131878f
@romantmb
Fix image name in docker-compose.yml
d6efd78
@romantmb
Revert replacing of empty strings and 'NULL's with null in COPY INTO …
6443d52 
…query
@romantmb
Delete obsolete tests of nullable & default date types
027c607
@romantmb
Copy test .csv files into each func. test, remove obsolete test of nu…
901ddfd 
…llable & default int field
@romantmb
Delete 'tests-prepare-data' script from composer.json
252c524
@romantmb
Add unit tests on PUT & COPY INTO queries
4781179
@romantmb
- remove STORAGE_API_TOKEN
c02c07e 
- replace `snowflake_writer` with `snowflake_writer_gcs` in README.md
- phpcs fix in SnowflakeWriteAdapter.php & SnowflakeTest.php
@romantmb
Improve push.yml, fix values
752f330
@romantmb
Update example configuration in README.md
09d3cf7
ondrajodas
ondrajodas reviewed Mar 13, 2024
View reviewed changes
src/Configuration/SnowflakeTableNodesDecorator.php Show resolved Hide resolved
src/SnowflakeApplication.php Show resolved Hide resolved
src/Writer/QuoteTrait.php Show resolved Hide resolved
src/Writer/SnowflakeWriteAdapter.php Outdated Show resolved Hide resolved
src/Writer/SnowflakeWriteAdapter.php Outdated Show resolved Hide resolved
src/Writer/SnowflakeWriteAdapter.php Show resolved Hide resolved
tests/common-data/tables/special.csv Outdated Show resolved Hide resolved
src/Configuration/ValueObject/SnowflakeItemConfig.php Outdated Show resolved Hide resolved
ondrajodas
ondrajodas reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ondrajodas ondrajodas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jedna drobnost, jinak super 👍

src/Writer/SnowflakeWriteAdapter.php Outdated Show resolved Hide resolved
ondrajodas
ondrajodas approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ondrajodas ondrajodas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 LGTM

@romantmb romantmb merged commit f159443 into main Mar 14, 2024
4 checks passed
@romantmb romantmb deleted the roman-gmt-109 branch March 14, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrajodas ondrajodas ondrajodas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romantmb @ondrajodas