Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add post about certificates #1104

Merged
merged 9 commits into from
Jun 16, 2023
Merged

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Apr 10, 2023

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 5fe1801
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6481d0de58f8c00007ffb329
😎 Deploy Preview https://deploy-preview-1104--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments, will review other sections later on

content/blog/2023-04-20-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-04-20-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-04-20-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-04-20-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-04-20-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-04-20-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-04-20-certificate-improvements.md Outdated Show resolved Hide resolved
JorTurFer and others added 3 commits April 25, 2023 21:02
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer marked this pull request as ready for review April 25, 2023 19:17
@JorTurFer JorTurFer requested a review from a team as a code owner April 25, 2023 19:17
@JorTurFer JorTurFer changed the title WIP - docs: add post about certificates docs: add post about certificates Apr 25, 2023
@JorTurFer
Copy link
Member Author

I have applied all the suggestions, PTAL @tomkerkhove

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I forgot to hit publish, sorry.

content/blog/2023-05-02-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-05-02-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-05-02-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-05-02-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-05-02-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-05-02-certificate-improvements.md Outdated Show resolved Hide resolved

The KEDA operator is responsible for generating certificates for all the services, this behaviour can be disabled removing the console argument `--enable-cert-rotation=true` or setting it to `false`. Once this setting is disabled, user given certs can be placed in the secret `kedaorg-certs` which is automatically mounted in all the components or they can be patched to use other secret (this can be done through helm values too).

All components inspect the folder `/certs` for any certificates inside it. Argument `--cert-dir` can be used to specify another folder to be used as a source for certificates, this argument can be patched in the manifests or using Helm values.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"inspect" or "expected to be in"? Not sure what you mean here. This sentence feels a bit odd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that all the components check the content of the folder '/certs' looking for certificates

content/blog/2023-05-02-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-05-02-certificate-improvements.md Outdated Show resolved Hide resolved
content/blog/2023-05-02-certificate-improvements.md Outdated Show resolved Hide resolved
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
@JorTurFer
Copy link
Member Author

Kindly reminder: PTAL @tomkerkhove

@JorTurFer
Copy link
Member Author

Kindly reminder: PTAL @tomkerkhove

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JorTurFer JorTurFer merged commit 360b71d into kedacore:main Jun 16, 2023
@JorTurFer JorTurFer deleted the post-certificates branch June 16, 2023 19:02
shavgath pushed a commit to shavgath/keda-docs that referenced this pull request Jun 19, 2023
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Shavgath Perumal <[email protected]>
zroubalik pushed a commit that referenced this pull request Jun 19, 2023
* Welcome Pollinate, a new KEDA user!

Signed-off-by: Shavgath Perumal <[email protected]>

* Include docs about Google Managed Prometheus on Prometheus scaler (#1153)

Signed-off-by: Shavgath Perumal <[email protected]>

* docs: dynamodb index name (#1154)

Signed-off-by: Shavgath Perumal <[email protected]>

* Welcome Devtron, a KEDA user as well as promoter! (#1155)

Signed-off-by: Shavgath Perumal <[email protected]>

* docs: add post about certificates (#1104)

Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Shavgath Perumal <[email protected]>

---------

Signed-off-by: Shavgath Perumal <[email protected]>
Co-authored-by: Claudio Netto <[email protected]>
Co-authored-by: Benjamin Haegenlaeuer <[email protected]>
Co-authored-by: Pawan Kumar <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants