-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add post about certificates #1104
Conversation
Signed-off-by: Jorge Turrado <[email protected]>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments, will review other sections later on
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
I have applied all the suggestions, PTAL @tomkerkhove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I forgot to hit publish, sorry.
|
||
The KEDA operator is responsible for generating certificates for all the services, this behaviour can be disabled removing the console argument `--enable-cert-rotation=true` or setting it to `false`. Once this setting is disabled, user given certs can be placed in the secret `kedaorg-certs` which is automatically mounted in all the components or they can be patched to use other secret (this can be done through helm values too). | ||
|
||
All components inspect the folder `/certs` for any certificates inside it. Argument `--cert-dir` can be used to specify another folder to be used as a source for certificates, this argument can be patched in the manifests or using Helm values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"inspect" or "expected to be in"? Not sure what you mean here. This sentence feels a bit odd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant that all the components check the content of the folder '/certs' looking for certificates
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Kindly reminder: PTAL @tomkerkhove |
Kindly reminder: PTAL @tomkerkhove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Shavgath Perumal <[email protected]>
* Welcome Pollinate, a new KEDA user! Signed-off-by: Shavgath Perumal <[email protected]> * Include docs about Google Managed Prometheus on Prometheus scaler (#1153) Signed-off-by: Shavgath Perumal <[email protected]> * docs: dynamodb index name (#1154) Signed-off-by: Shavgath Perumal <[email protected]> * Welcome Devtron, a KEDA user as well as promoter! (#1155) Signed-off-by: Shavgath Perumal <[email protected]> * docs: add post about certificates (#1104) Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Shavgath Perumal <[email protected]> --------- Signed-off-by: Shavgath Perumal <[email protected]> Co-authored-by: Claudio Netto <[email protected]> Co-authored-by: Benjamin Haegenlaeuer <[email protected]> Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]>
Provide a description of what has been changed
Checklist
Fixes #