-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a detailed description of the "idleReplicaCount" field, along with an example. #1186
Add a detailed description of the "idleReplicaCount" field, along with an example. #1186
Conversation
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about:
|
552cb5f
to
3153526
Compare
Is there somebody help me to review it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Could you please update more versions?
At least 2.9, 2.10 and 2.13?
3153526
to
c440bb6
Compare
…an example. Signed-off-by: mahone3297 <[email protected]>
c440bb6
to
09b7f68
Compare
@zroubalik I have updated the code. Now it covers the version 2.9, 2.10, 2.11, 2.12, 2.13. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Related to kedacore/keda#2314, some people discussed there.
So, I gather the keypoint infomation and write it into the docs.
Checklist
Fixes kedacore/keda#2314