Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a detailed description of the "idleReplicaCount" field, along with an example. #1186

Merged

Conversation

mahone3297
Copy link
Contributor

@mahone3297 mahone3297 commented Jul 14, 2023

Related to kedacore/keda#2314, some people discussed there.
So, I gather the keypoint infomation and write it into the docs.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#2314

@mahone3297 mahone3297 requested a review from a team as a code owner July 14, 2023 07:38
@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 09b7f68
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6566c55dacae83000896620b
😎 Deploy Preview https://deploy-preview-1186--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@mahone3297
Copy link
Contributor Author

Is there somebody help me to review it ?

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Could you please update more versions?

At least 2.9, 2.10 and 2.13?

@mahone3297 mahone3297 force-pushed the scaling-deployments-idleReplicaCount branch from 3153526 to c440bb6 Compare November 29, 2023 04:39
@mahone3297 mahone3297 force-pushed the scaling-deployments-idleReplicaCount branch from c440bb6 to 09b7f68 Compare November 29, 2023 05:00
@mahone3297
Copy link
Contributor Author

@zroubalik I have updated the code. Now it covers the version 2.9, 2.10, 2.11, 2.12, 2.13. Please review.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 67c2cda into kedacore:main Nov 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaling is flapping when idleReplicaCount != 0
2 participants