Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix website layout to render correctly on mobile #796

Merged
merged 7 commits into from
Jun 29, 2022

Conversation

thisisobate
Copy link
Contributor

@thisisobate thisisobate commented Jun 28, 2022

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #582

@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit f278a50
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/62bb62f803c279000836cf71
😎 Deploy Preview https://deploy-preview-796--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thisisobate thisisobate marked this pull request as draft June 28, 2022 06:32
@JorTurFer
Copy link
Member

I'm not sure if it due to these changes or simply because netfly doesn't render it correctly on PRs, but I can see the icons not aligned in the preview and in keda.sh they are aligned. Could you check it? 🙏
image

@thisisobate
Copy link
Contributor Author

Yeah...noticed some minor deviations too.
Would fix up

@thisisobate thisisobate marked this pull request as ready for review June 28, 2022 19:25
@tomkerkhove tomkerkhove merged commit e6bdca7 into kedacore:main Jun 29, 2022
@chalin
Copy link
Contributor

chalin commented Jun 29, 2022

Great fix @thisisobate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website does not render correctly on mobile
4 participants