Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make propagationPolicy configurable during job rollout #3338

Merged
merged 5 commits into from
Jul 18, 2022

Conversation

FullyScaled
Copy link
Contributor

@FullyScaled FullyScaled commented Jul 7, 2022

Signed-off-by: Jonas Bentz [email protected]

This PR allows to configure the kubernetes propagation policy during job scaled roll out.
In some usecases (see Issue #2910) its required to use foreground propagation instead of background propagation during rollout.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2910

Relates to # kedacore/keda-docs#804

@FullyScaled FullyScaled marked this pull request as ready for review July 7, 2022 10:41
@FullyScaled FullyScaled requested a review from a team as a code owner July 7, 2022 10:41
Signed-off-by: d062452 <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Jul 11, 2022

/run-e2e
Update: You can check the progress here

Update from @JorTurFer :
This workflow has been autocancelled due to a concurrency problem that we have to solve

CHANGELOG.md Outdated Show resolved Hide resolved
controllers/keda/scaledjob_controller.go Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Jul 11, 2022

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Jul 11, 2022

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik merged commit d6eb3d2 into kedacore:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScaledJob Scaler does not take "Terminating" Pods into consideration
4 participants