Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to use pod identities for authentication in Azure Key Vault #3814

Merged
merged 6 commits into from
Nov 4, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Nov 3, 2022

Signed-off-by: Jorge Turrado [email protected]

This PR adds explicit support to use podIdentity only for Azure Key Vault and not for all scaler related things

Checklist

Fixes #3813

@JorTurFer JorTurFer requested a review from a team as a code owner November 3, 2022 23:35
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 3, 2022

/run-e2e keyvault*
Update: You can check the progress here

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 3, 2022

/run-e2e keyvault*
Update: You can check the progress here

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 4, 2022

/run-e2e keyvault*
Update: You can check the progress here

pkg/scaling/resolver/azure_keyvault_handler.go Outdated Show resolved Hide resolved
pkg/scaling/resolver/azure_keyvault_handler.go Outdated Show resolved Hide resolved
pkg/scaling/resolver/azure_keyvault_handler.go Outdated Show resolved Hide resolved
@v-shenoy
Copy link
Contributor

v-shenoy commented Nov 4, 2022

Besides the changes in 2.9 docs for adding this feature, we would require some changes in the earlier docs (I think 2.7, 2.8) to report this problem, right?

@JorTurFer
Copy link
Member Author

Besides the changes in 2.9 docs for adding this feature, we would require some changes in the earlier docs (I think 2.7, 2.8) to report this problem, right?

I wouldn't change them, the feature it isn't documented in those version, so officially it doesn't exist xD

@v-shenoy
Copy link
Contributor

v-shenoy commented Nov 4, 2022

I enabled pod identity / workload identity for key vault in #2907.
And I added to the docs as well in kedacore/keda-docs#752.

But now that I look at it, the page for keyvault still mentions that pod identity is not supported. Funny.

@JorTurFer
Copy link
Member Author

But now that I look at it, the page for keyvault still mentions that pod identity is not supported. Funny.

That's why I said that it isn't documented xD
Maybe it was an error adding the files to the stage... I'll document this as part of v2.9, and I guess we don't need to update previous versions to explain it

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 4, 2022

/run-e2e keyvault*
Update: You can check the progress here

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 4, 2022

/run-e2e keyvault*
Update: You can check the progress here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pod identities to Azure Key Vault provider
3 participants