Apache Pulsar: Add support for partitioned topics #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaeljmarshall looking good, could you please rebase the branch? |
zroubalik
reviewed
Nov 10, 2022
Signed-off-by: Michael Marshall <[email protected]>
michaeljmarshall
force-pushed
the
support-pulsar-partitioned-topics
branch
from
3364691
to
1b55abd
Compare
Signed-off-by: Michael Marshall <[email protected]>
michaeljmarshall
force-pushed
the
support-pulsar-partitioned-topics
branch
from
1b55abd
to
d238070
Compare
|
/run-e2e pulsar* |
|
@michaeljmarshall e2e test failed. |
Signed-off-by: Michael Marshall <[email protected]>
|
Thanks @zroubalik. I tested locally and think these changes should work now. |
|
/run-e2e pulsar* |
zroubalik
approved these changes
Nov 11, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Marshall [email protected]
Apache Pulsar has topics and partitioned topics. In order to support scaling partitioned topics, the Scaler needs to call a different stats endpoint. The data returned by that endpoint is in the same format as the one returned by the non-partitioned stats endpoint.
Checklist
Fixes #3833
Relates kedacore/keda-docs#975