Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate old Azure SDKs into to use github.com/Azure/azure-sdk-for-go/sdk/azidentity #5471

Merged
merged 26 commits into from
Jul 24, 2024
Merged

Migrate old Azure SDKs into to use github.com/Azure/azure-sdk-for-go/sdk/azidentity #5471

merged 26 commits into from
Jul 24, 2024

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Feb 2, 2024 •
edited
Loading

This PR has migrated some old Azure SDKs into the (unified) new one

  • EventHub: github.com/Azure/azure-event-hubs-go/v3 -> github.com/Azure/azure-sdk-for-go/sdk/messaging/azeventhubs
  • Blob Storage: github.com/Azure/azure-storage-blob-go -> github.com/Azure/azure-sdk-for-go/sdk/storage/azblob
  • Storage queues: github.com/Azure/azure-storage-queue-go -> github.com/Azure/azure-sdk-for-go/sdk/storage/azqueue
  • Azure Key Vault: github.com/Azure/azure-sdk-for-go -> github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azsecrets
  • Azure Monitor: github.com/Azure/azure-sdk-for-go -> github.com/Azure/azure-sdk-for-go/sdk/monitor/azquery
  • Azure Log Analytics: no-sdk -> github.com/Azure/azure-sdk-for-go/sdk/monitor/azquery
  • Azure Data Explorer: github.com/Azure/azure-kusto-go/kusto uses github.com/Azure/azure-sdk-for-go/sdk/azidentity
  • Azure Application Insights: Currently it's not supported, I've opened and issue asking for it for migrating it in the future

Additionally to improve the testing experience, I've replaced go test ... | junit.... with gotestsum -> https://github.com/gotestyourself/gotestsum

Checklist

Fixes #5470

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 2, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 2, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer JorTurFer changed the title Migrate Azure EventHub and Azure Storage SDKs Migrate old Azure SDKs into github.com/Azure/azure-sdk-for-go Feb 2, 2024
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 2, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 2, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 2, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 2, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 6, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer JorTurFer changed the title Migrate old Azure SDKs into github.com/Azure/azure-sdk-for-go Migrate old Azure SDKs into to use github.com/Azure/azure-sdk-for-go/sdk/azidentity Feb 6, 2024
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 6, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Feb 6, 2024
Open
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 6, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer JorTurFer marked this pull request as ready for review February 13, 2024 21:08
@JorTurFer JorTurFer requested a review from a team as a code owner February 13, 2024 21:08
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 13, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Mar 11, 2024
Merged
7 tasks
@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 30, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 30, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

zroubalik
zroubalik reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JorTurFer what is the status on this please?

@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 10, 2024 •
edited
Loading

It's ready to merge from code pov (just pending to rebase main branch). But I think that waiting until v2.14 is released could be a good idea because I'm not 100% sure if I have dropped some AAD-Pod-Identity support and taking into account that v2.15 will remove AAD-Pod-Identity I'm more confident adding this after removing AAD-Pod-Identity.

@zroubalik
Copy link
Member

zroubalik commented Apr 10, 2024 •
edited by JorTurFer
Loading

It's ready to merge from code pov (just pending to rebase main branch). But I think that waiting until v2.14 is released could be a good idea because I'm not 100% sure if I have dropped some AAD-Pod-Identity support and taking into account that v2.15 will remove AAD-Pod-Identity I'm more confident adding this after removing AAD-Pod-Identity.

Okay, sounds good!

@tomkerkhove tomkerkhove mentioned this pull request Apr 16, 2024
Closed
35 tasks
@JorTurFer JorTurFer mentioned this pull request May 4, 2024
Merged
4 tasks
@JorTurFer
Copy link
Member Author

time to rebase :)

@JorTurFer
sort
8ba3a9d 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
migrate storage SDK
5890252 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
update changelog and style
3b61dba 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
migrate key vault
73388e5 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix typos
2fc31fd 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Update azure monitor
f06c210 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix typo
fb75227 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix e2e tests
c4f32f9 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix error
b4d2301 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
use AZQUERY FOR MONITOR
be9859b 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix style
23707ca 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
use client optiosn
76ae136 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
use sdk parsing function
6c63dc9 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
migrate log analytics
eec89ea 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
update tokens
de93d80 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
style
26192dd 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix typo
a6b1956 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Add missing changes
5500761 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
bump azure deps
0aefea2 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix packages
edc11d2 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix code
65ed041 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix test
c375985 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix styles
25b4902 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
remove todos
bb57d22 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 24, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 24, 2024 •
edited by github-actions bot
Loading

/run-e2e prometheus_metrics_test
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 24, 2024 •
edited by github-actions bot
Loading

/run-e2e prometheus_metrics_test
Update: You can check the progress here

@JorTurFer JorTurFer merged commit ebc8975 into kedacore:main Jul 24, 2024
18 checks passed
@JorTurFer JorTurFer deleted the migrate-eventhub-sdk branch July 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Azure Event Hub and Storage to the new SDK
2 participants
@JorTurFer @zroubalik