Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasets): Add rioxarray and RasterDataset #355
feat(datasets): Add rioxarray and RasterDataset #355
Changes from all commits
0bffa11
cc13fd6
0a83de4
406dffd
9b32d79
b2fc87f
661eebb
4f6df5c
eea4690
1fa31c7
2049431
a9bd48f
9c150ea
7ba1506
ca43610
f322147
b01a018
461fd02
c6d54ea
7308b59
4373360
d0a2832
427ea75
c63fc1b
897a8f5
dc47f76
9541e25
2a3e3ee
3e3569b
e4710ee
cdf8e96
6cf15e2
0616cea
bef94bb
ed26c52
ae568cc
7ee7c6d
1587eee
c2f52f5
02aa70d
82ac8c9
132bf37
53f0fe5
727ed81
f241464
f26406f
b60a5f4
1d3094c
9419821
bbdc89a
68b731a
a43ef5b
c4d2c18
b41cd20
2cd79bb
4214432
ba64102
a216b21
58af6eb
8948d4a
f26b950
72abd95
f5d7e71
2940376
158056f
469f201
e855ed9
388192e
48557d2
e8946f7
9bdeefb
ffeef40
41c9e7e
5ea5594
f6d4f79
ecad5d5
f25ebb6
da3f8c2
bc02b27
abfa97f
677d0a2
79f58a9
d7b0395
bf4e1b7
000f715
b089ff5
ac53eb0
e96f705
339f7d5
46e3b84
272d0c8
a8aa3dd
92583c4
63a8e67
31c4b31
b07bf75
2f69ced
3591ec2
3c0788f
2624e4a
949ad5d
c75bd3d
8546022
b04daab
abc549b
f12fb39
9cab70c
4027516
16f218e
8ad0ecd
17aa70e
f3ba239
c5dfa43
6504217
3dc954c
fb3fb5c
b7cf4b3
8cdb8db
90c037c
695cdd3
3978a00
2f58c1e
8e7123d
9c51583
df12088
9339a46
f6218b9
448e7aa
1a5d0a1
5029f30
d023b5c
0d95de5
9b7aecc
1998edb
217bea3
1377b20
551f86b
3b0bd53
6884f6b
267d35d
b5b82c6
a864a4f
d54de28
b1f16c9
cd83be8
25a23e8
23b6393
5256c83
7e992a0
4e0f798
3dc6731
1f4c8f8
5a6041d
f7c6f5f
aa487d8
34a7731
17d91b9
9c1bfa3
2e96c9f
0edf586
9b1c920
e456b69
fb22a25
4d7da9e
7571403
c38ecd7
dc599e1
4aefa76
05aadfe
b8bd15f
cac93e6
88b627d
5828a1d
850fcd7
6e52420
67f9916
38d6f01
56d3e4d
5905872
1e22c89
b2fd842
41736e9
90d2295
27d52dd
d89f764
c98fd71
89867d9
4ce267b
82ddeb8
88a77d2
43f3932
cf8291d
15451dc
823e63b
5989f44
1fdf5ac
2c0a504
8c53ed6
12b16f6
f1823c5
e9c16d9
b0fbc08
86599d3
8e53b4e
d2f6685
321aa97
5330eed
6df47a9
974ab1a
b81c694
156b2f4
8ad4870
c90fa6c
2560ebf
cc856f3
e193107
41455ec
07cb647
22073f7
2d80027
5959ef4
649a76e
04aeb91
a4c00c7
c898af8
889ec71
985ed6e
c48a7ac
47f5b01
3fd61e5
a0a5047
e170146
cd9ceb4
959723c
8f3c540
1e5f6a5
6f34def
bd08ab2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried using the dataset with a remote path and it didn't work:
But
rasterio
knows how to deal with remote paths:so maybe there's something wrong in how the load path is handled here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astrojuanlu Use get_filepath_str instead
The reason is that
self._get_load_path
doesn't handle protocols correctly. I suggest we merge this now and handle this separately as I think it probably affect more than 1 datasetThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree!