feat: add matlab dataset into kedro-datasets

[samuel-lee-sj]

Description

This is implementation of a .mat dataset from MatLab for kedro

Development notes

Added two files, matlab_dataset.py, test_matlab_dataset.py. Tested on pytest.

Checklist

• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change in the relevant RELEASE.md file
• Added tests to cover my changes

[astrojuanlu]

Thanks a lot for your pull request @samuel-lee-sj ! We'll need a couple of iterations for this to be ready, but this is a great start 💪🏽

You can also do make lint plugin=kedro-datasets (from the kedro-plugins directory) to automatically lint the code

[samuel-lee-sj]

When I try
'make lint plugin=kedro-datasets'

I get an error saying 'No hook with id 'ruff-' in stage 'manual'.
I looked in the .pre-commit-config.yaml and found it. So I am unsure why the error surfaced.

Below is the full error message:

(kedro) PS G:\Working\kedro-plugins\kedro-plugins> make lint plugins=kedro-datasets
pre-commit run -a --hook-stage manual ruff- && pre-commit run trailing-whitespace --all-files && pre-commit run end-of-file-fixer --all-files && pre-commit run check-yaml --all-files && pre-commit run check-added-large-files --all-files && pre-commit run check-case-conflict --all-files && pre-commit run check-merge-conflict --all-files && pre-commit run debug-statements --all-files && pre-commit run black- --all-files --hook-stage manual && pre-commit run secret_scan --all-files --hook-stage manual && pre-commit run bandit --all-files --hook-stage manual
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/adamchainz/blacken-docs.
[INFO] Initializing environment for https://github.com/adamchainz/blacken-docs:black==22.12.0.
No hook with id ruff- in stage manual
make: *** [Makefile:17: lint] Error 1

[astrojuanlu]

@samuel-lee-sj it's because of a typo: you wrote plugins= instead of plugin=, so the $(plugin) variable was empty and ruff- was attempted unsuccessfully:

kedro-plugins/Makefile

Lines 16 to 17 in f59e930

lint:

pre-commit run -a --hook-stage manual ruff-$(plugin) && pre-commit run trailing-whitespace --all-files && pre-commit run end-of-file-fixer --all-files && pre-commit run check-yaml --all-files && pre-commit run check-added-large-files --all-files && pre-commit run check-case-conflict --all-files && pre-commit run check-merge-conflict --all-files && pre-commit run debug-statements --all-files && pre-commit run black-$(plugin) --all-files --hook-stage manual && pre-commit run secret_scan --all-files --hook-stage manual && pre-commit run bandit --all-files --hook-stage manual

[merelcht]

Hi @samuel-lee-sj , would you like to continue this PR or do you need some help finishing it?

[samuel-lee-sj]

Hello @merelcht. I was under the impression that @ankatiyar was going to takeover. Let me know what you think!

[ankatiyar]

@samuel-lee-sj Could you fix the sign-off on the commits by following the instructions here and I can help with the rest! 😄

[samuel-lee-sj]

Hello @ankatiyar. I think I did it. Let me know if there are any more problems.

[ankatiyar]

@samuel-lee-sj, seems like the DCO test is still not passing. Would you mind trying rebasing again?

[samuel-lee-sj]

Hello @ankatiyar. I think I messed up the rebase. Could you give me some help?

The DCO is saying that:
Commit sha: bc76e83, Author: Merel Theisen, Committer: samuelleeshemen; Can not find "Merel Theisen [email protected]", in ["Merel Theisen [email protected]", "Merel Theisen [email protected]", "Merel Theisen [email protected]"].

I don't think I edited this commit. If I did I am sorry.