Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(datasets): Move NetCDFDataset to experimental #739

Merged
merged 3 commits into from
Jun 21, 2024
Merged

refactor(datasets): Move NetCDFDataset to experimental #739

merged 3 commits into from
Jun 21, 2024

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Jun 19, 2024 •
edited
Loading

Description

Proposal for the TSC: Move NetCDFDataset to experimental datasets. Please vote with PR approvals
Will only merge at 1/2 TSC vote = 11 approvals!
Reason:

cc: @riley-brady as the original contributor, would like your opinion as well!

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@ankatiyar
Move NetCDFDataset to experimental
dc4f2dc 
Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar
release notes and fix reqs
cfba9a2 
Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar
Docs test
3d2ec2b 
Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar ankatiyar marked this pull request as ready for review June 19, 2024 16:49
@ankatiyar ankatiyar requested a review from a team June 19, 2024 16:53
@Galileo-Galilei
Copy link
Contributor

Completely agree, but this is not a retro compatible change, so this mean next release should be a major release?

@noklam noklam self-requested a review June 20, 2024 09:56
riley-brady
riley-brady approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@riley-brady riley-brady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to me. Admittedly, I don't fully understand the implications. But helps relieve the issues we had with weird testing bugs.

@astrojuanlu
Copy link
Member

Admittedly, I don't fully understand the implications.

More than anything, it's a way for the TSC to relieve part of the maintenance load.

@jitu5 jitu5 self-requested a review June 21, 2024 15:51
@ravi-kumar-pilla ravi-kumar-pilla self-requested a review June 21, 2024 15:52
@ankatiyar ankatiyar merged commit bf6596a into main Jun 21, 2024
15 checks passed
@ankatiyar ankatiyar deleted the experimental-netcdf branch June 21, 2024 15:53
@ankatiyar ankatiyar mentioned this pull request Jun 21, 2024
Closed
merelcht pushed a commit to galenseilis/kedro-plugins that referenced this pull request Aug 27, 2024
@ankatiyar @merelcht
refactor(datasets): Move NetCDFDataset to experimental (kedro-org#739)
807fa43 
* Move NetCDFDataset to experimental

Signed-off-by: Ankita Katiyar <[email protected]>

* release notes and fix reqs

Signed-off-by: Ankita Katiyar <[email protected]>

* Docs test

Signed-off-by: Ankita Katiyar <[email protected]>

---------

Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@sbrugman sbrugman sbrugman approved these changes

@deepyaman deepyaman deepyaman approved these changes

@noklam noklam noklam approved these changes

@Galileo-Galilei Galileo-Galilei Galileo-Galilei approved these changes

@datajoely datajoely datajoely approved these changes

@jitu5 jitu5 jitu5 approved these changes

@DimedS DimedS DimedS approved these changes

@merelcht merelcht merelcht approved these changes

@lrcouto lrcouto lrcouto approved these changes

@riley-brady riley-brady riley-brady approved these changes

@ravi-kumar-pilla ravi-kumar-pilla ravi-kumar-pilla approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.