Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.12 to starters builds #219

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Add python 3.12 to starters builds #219

merged 3 commits into from
Apr 24, 2024

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Apr 23, 2024

Motivation and Context

Noticed that 3.12 builds were missing!

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@ankatiyar
Copy link
Contributor Author

distutils removed in Python 3.12 🤔

@ElenaKhaustova
Copy link
Contributor

distutils removed in Python 3.12 🤔

Yeah, https://docs.python.org/3.12/whatsnew/3.12.html#distutils

@ankatiyar ankatiyar marked this pull request as draft April 23, 2024 13:38
@ankatiyar
Copy link
Contributor Author

@ankatiyar
Copy link
Contributor Author

Adding setuptools to the requirements.txt for spaceflights-pandas-viz for python 3.12 does solve the issue but the tools.feature test will fail still because it pulls the last released version of starters.
Here's what we can do -

  • Separate PR for adding setuptools to the requirements.txt will only run tests till 3.11 so can be merged
  • Delete and re-tag 0.19.5 on starters
  • Then add "3.12" to the builds

What do you think @ElenaKhaustova @astrojuanlu @noklam?
Or we could wait till pyspark 4.0.0 comes out.
We have already added support for python 3.12 in the last release on Kedro, this should technically have been a part of 0.19.4

@noklam
Copy link
Contributor

noklam commented Apr 23, 2024

Is this a build or project requirements? Usually setuptools is a build requirements and we tried very hard in the past to remove it from kedro library depedencies (it's big and slow, used for micropkg)

@ankatiyar
Copy link
Contributor Author

@noklam just adding it to the requirements.txt for the spaceflights-pyspark-viz starter (only if python_version>3.11)
https://stackoverflow.com/questions/77233855/why-did-i-got-an-error-modulenotfounderror-no-module-named-distutils
Wouldn't need it after pyspark releases 4.0.0

@noklam
Copy link
Contributor

noklam commented Apr 23, 2024

After reading the JIRA issue, I think it's okay to included it in requirements.txt conditionally for >=3.12. It's a shame PySpark didn't support this. We should leave a comment in the requirements too.

@ElenaKhaustova
Copy link
Contributor

ElenaKhaustova commented Apr 23, 2024

@noklam just adding it to the requirements.txt for the spaceflights-pyspark-viz starter (only if python_version>3.11) https://stackoverflow.com/questions/77233855/why-did-i-got-an-error-modulenotfounderror-no-module-named-distutils Wouldn't need it after pyspark releases 4.0.0

I agree with this, as it seems reasonable. We can also open a ticket along with leaving comments to update after pyspark releases 4.0.0.

@ankatiyar
Copy link
Contributor Author

All done! ✅

@ankatiyar ankatiyar enabled auto-merge (squash) April 24, 2024 12:53
@ankatiyar ankatiyar merged commit db79aec into main Apr 24, 2024
22 of 23 checks passed
@ankatiyar ankatiyar deleted the python-3.12 branch April 24, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants