Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download to SVG broken #1290

Closed
yetudada opened this issue Mar 21, 2023 · 5 comments · Fixed by #1463
Closed

Download to SVG broken #1290

yetudada opened this issue Mar 21, 2023 · 5 comments · Fixed by #1463
Assignees
@ravi-kumar-pilla
Labels
Issue: Bug Report Quick Win Low/Medium priorities but quick to do

Comments

@yetudada
Copy link
Contributor

Description

I downloaded a pipeline using the SVG option from the demo and found this:

Screenshot 2023-03-21 at 13 57 19
@tynandebold
Copy link
Member

How did you open this SVG?

It works fine for me:

image

@yetudada
Copy link
Contributor Author

Ah, that's weird. I brought it into Microsoft Powerpoint and SVGs normally work there.

@tynandebold
Copy link
Member

Could you check your downloaded file with this tool please? https://svg.enshrined.co.uk/

You can paste the SVG code, click Sanitize, and then see what comes out.

It worked fine for my downloaded SVG file.

@tynandebold
Copy link
Member

Going to close this, as @rashidakanchwala confirmed she downloaded and previewed the SVG without issue.

@tynandebold tynandebold closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2023
@tynandebold
Copy link
Member

tynandebold commented Jul 17, 2023 •
edited
Loading

Reopening because we do see it here: https://products.groupdocs.app/viewer/app?lang=en&file=4aeb7c10-9fb6-481f-ac90-a257d574aa16/kedro-pipeline%20(5).svg

Also, the edges aren't visible when the light theme is used to download the SVG:

image

@tynandebold tynandebold reopened this Jul 17, 2023
@tynandebold tynandebold added the Quick Win Low/Medium priorities but quick to do label Jul 25, 2023
@ravi-kumar-pilla ravi-kumar-pilla self-assigned this Jul 26, 2023
@ravi-kumar-pilla ravi-kumar-pilla mentioned this issue Jul 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravi-kumar-pilla ravi-kumar-pilla

Labels
Issue: Bug Report Quick Win Low/Medium priorities but quick to do
Projects
Kedro-Viz
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for broken svg/png exports in light theme kedro-org/kedro-viz
3 participants
@tynandebold @yetudada @ravi-kumar-pilla