Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken svg/png exports in light theme #1463

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Jul 26, 2023

Description

Resolves #1290

Development notes

  • Modified the --edge-stroke value of export mixin inside .kui-theme--light from white to black

Downloaded SVG Image
kedro-pipeline_light

Downloaded PNG Image

image

QA notes

  • Export the flowchart using the Download SVG/PNG button and the edges should appear in black when light theme is enabled

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The light-theme SVG looks much better now. Thank you for the quick fix on that.

I'm still seeing some strangeness when I try and view the SVG in this document viewer tool, which is the same problem that Yetu originally reported in the issue.

Try opening the SVG in PowerPoint and seeing what you get? If it still has all those black fills and doesn't render correctly we'll need to continue working on this.

@@ -26,7 +26,7 @@
@mixin export {
--node-fill-default: #{colors.$white-200};
--node-stroke-default: #{colors.$white-900};
--edge-stroke: colors.$white-900;
--edge-stroke: #{colors.$black-100};
--edge-arrowhead-fill: colors.$white-900;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might also need to be wrapped in #{ } as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the arrow head style as it is not needed

@ravi-kumar-pilla
Copy link
Contributor Author

I'm still seeing some strangeness when I try and view the SVG in this document viewer tool, which is the same problem that Yetu originally reported in the issue.

Try opening the SVG in PowerPoint and seeing what you get? If it still has all those black fills and doesn't render correctly we'll need to continue working on this.

It is better to use png file to import the image into ppt as discussed. Powerpoint may have issues rendering the svg images and it is suggested to use png.

I do not see a way to fix the ppt import issue as the svg is rendering fine when viewed in chrome or other browser windows. Thank you !

Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please add a line to the release notes for this fix.

RELEASE.md Outdated Show resolved Hide resolved
Co-authored-by: Tynan DeBold <[email protected]>
@ravi-kumar-pilla ravi-kumar-pilla merged commit eb8139d into main Aug 1, 2023
1 check passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/broken-svg branch August 1, 2023 15:24
@tynandebold tynandebold mentioned this pull request Aug 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download to SVG broken
3 participants