-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for broken svg/png exports in light theme #1463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The light-theme SVG looks much better now. Thank you for the quick fix on that.
I'm still seeing some strangeness when I try and view the SVG in this document viewer tool, which is the same problem that Yetu originally reported in the issue.
Try opening the SVG in PowerPoint and seeing what you get? If it still has all those black fills and doesn't render correctly we'll need to continue working on this.
@@ -26,7 +26,7 @@ | |||
@mixin export { | |||
--node-fill-default: #{colors.$white-200}; | |||
--node-stroke-default: #{colors.$white-900}; | |||
--edge-stroke: colors.$white-900; | |||
--edge-stroke: #{colors.$black-100}; | |||
--edge-arrowhead-fill: colors.$white-900; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might also need to be wrapped in #{ }
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the arrow head style as it is not needed
It is better to use png file to import the image into ppt as discussed. Powerpoint may have issues rendering the svg images and it is suggested to use png. I do not see a way to fix the ppt import issue as the svg is rendering fine when viewed in chrome or other browser windows. Thank you ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Please add a line to the release notes for this fix.
Co-authored-by: Tynan DeBold <[email protected]>
Description
Resolves #1290
Development notes
Downloaded SVG Image
Downloaded PNG Image
QA notes
Checklist
RELEASE.md
file