Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise layout.html for docs projects for Viz, Framework and Datasets #1618

Closed
1 task done
stichbury opened this issue Oct 31, 2023 · 1 comment
Closed
1 task done
Assignees

Comments

@stichbury
Copy link
Contributor

stichbury commented Oct 31, 2023

This issue forms part of the ongoing work to enable a documentation subproject for Kedro-Viz. See #1524 for more details (and the kedro-org/kedro#2600).

@tynandebold Please could someone with front-end skills make some changes to the layout.html files that we'll be using for docs subprojects? They need to be adjusted to align with design feedback from @stephkaiser which is recorded in #1592 as follows:

For Viz

You can commit to my PR: #1617

Docs are currently building to look like this: image

You can find the docs built here

Changes needed

  • Revise top left to have the diamond + kedro logotype
  • Remove version (latest/stable) that follows the logo/type at the top left hand corner
This is a mock design:

image


For Framework

Also needs someone with front-end skills please.

You can commit to my PR: kedro-org/kedro#3206

Docs are currently building to look like this: image

You can find a preview of the docs here

Changes needed

  • No need to change the logo/type as this is fine for the framework (it's what we need for Viz too, see above)
  • Remove version (latest/stable or build preview number) that follows the logo/type at the top left hand corner

For Datasets

Also needs someone with front-end skills please.

You can commit to my PR: kedro-org/kedro-plugins#400

Docs are currently building to look like this: image

You can find a preview of the docs here

Changes needed

  • General sort-out of the presentation as it's a bit of a jumble right now
  • Change the logo/type to match Viz and Framework as above
  • Remove version (latest/stable or build preview number) that follows the logo/type at the top left hand corner (if it's displayed, I cannot completely see it).

Context

Implements design feedback from #1592

Checklist

  • Include labels so that we can categorise your feature request
@tynandebold
Copy link
Member

I'm closing this as completed. I've added the full logo treatment to all three docs projects, removed the version label, and updated the logo size in the shared CSS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants