-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft, not ready] Update docs front page following design review #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jo Stichbury <[email protected]>
1 task
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
…/kedro-viz into update-docs-front-page
Signed-off-by: Tynan DeBold <[email protected]>
…/kedro-viz into update-docs-front-page Signed-off-by: Tynan DeBold <[email protected]>
stichbury
requested review from
tynandebold,
yetudada and
rashidakanchwala
as code owners
November 1, 2023 15:52
tynandebold
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great. Three comments from me, none of which I consider to be blocking, so I'll approve now.
I'm closing this PR by merging it into my other changes in #1628. |
stichbury
added a commit
that referenced
this pull request
Nov 13, 2023
* something to start off Signed-off-by: Jo Stichbury <[email protected]> * Fix permalink icon Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Revise some links to framework docs Signed-off-by: Jo Stichbury <[email protected]> * Add live tracking demo to open in new tab Signed-off-by: Jo Stichbury <[email protected]> * Remove code to load old CSS Signed-off-by: Jo Stichbury <[email protected]> * [Draft, not ready] Update docs front page following design review (#1617) * Update docs front page Signed-off-by: Jo Stichbury <[email protected]> * Remove nav_version next to Kedro logo in top left; add Kedro logo Signed-off-by: Tynan DeBold <[email protected]> * Revise project name and author name Signed-off-by: Jo Stichbury <[email protected]> * Use full kedro icon and type for logo Signed-off-by: Tynan DeBold <[email protected]> * Add mobile nav close btn * Move code for adding btn to event listener * Add css for mobile nav image background * Update close button for mobile nav --------- Signed-off-by: Jo Stichbury <[email protected]> Signed-off-by: Tynan DeBold <[email protected]> Co-authored-by: Tynan DeBold <[email protected]> Co-authored-by: Vladimir <[email protected]> Co-authored-by: vladimir-mck <[email protected]> * A few content improvements Signed-off-by: Jo Stichbury <[email protected]> * Update layout.html * Update layout.html * Delete docs/source/kedro-horizontal-color-on-light.svg * Update conf.py * Update layout.html Add datasets subproject link * Update Shareable Viz docs with sections on creating access key and billing. (#1631) * Update shareable viz docswith sections on creating access key and billing Signed-off-by: Nero Okwa <[email protected]> * Update docs/source/share_kedro_viz.md Co-authored-by: Tynan DeBold <[email protected]> * Update docs/source/share_kedro_viz.md Co-authored-by: Tynan DeBold <[email protected]> * Update docs/source/share_kedro_viz.md Co-authored-by: Tynan DeBold <[email protected]> * Update docs/source/share_kedro_viz.md Co-authored-by: Tynan DeBold <[email protected]> * Update docs/source/share_kedro_viz.md Co-authored-by: Tynan DeBold <[email protected]> * Update docs/source/share_kedro_viz.md Co-authored-by: Tynan DeBold <[email protected]> * Update docs/source/share_kedro_viz.md Co-authored-by: Tynan DeBold <[email protected]> * Update share_kedro_viz.md --------- Signed-off-by: Nero Okwa <[email protected]> Co-authored-by: Tynan DeBold <[email protected]> Co-authored-by: Jo Stichbury <[email protected]> * Update docs/source/conf.py * Update docs/source/preview_datasets.md Co-authored-by: Juan Luis Cano Rodríguez <[email protected]> * Update docs/source/visualise_charts_with_matplotlib.md Co-authored-by: Juan Luis Cano Rodríguez <[email protected]> * Update docs/source/share_kedro_viz.md Co-authored-by: Juan Luis Cano Rodríguez <[email protected]> * Update docs/source/visualise_charts_with_plotly.md Co-authored-by: Juan Luis Cano Rodríguez <[email protected]> * Update docs/source/preview_datasets.md Co-authored-by: Juan Luis Cano Rodríguez <[email protected]> * Suggested variable removal Signed-off-by: Jo Stichbury <[email protected]> * Fix links Signed-off-by: Jo Stichbury <[email protected]> --------- Signed-off-by: Jo Stichbury <[email protected]> Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> Signed-off-by: Tynan DeBold <[email protected]> Signed-off-by: Nero Okwa <[email protected]> Co-authored-by: Juan Luis Cano Rodríguez <[email protected]> Co-authored-by: Tynan DeBold <[email protected]> Co-authored-by: Vladimir <[email protected]> Co-authored-by: vladimir-mck <[email protected]> Co-authored-by: Nero Okwa <[email protected]> Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR forms part of the ongoing work to enable a documentation subproject for Kedro-Viz. See #1524 for more details (and the kedro-org/kedro#2600).
Development notes
Updated the docs front page following design review in #1592.
README.md
on the repoCurrently waiting to make a final chunk of changes to align this PR with meganav improvements as suggested by Steph in design review. So this is not yet ready to merge.
QA notes
Rebuilt docs and inspected
Checklist
RELEASE.md
file