Fix Safari blank page when clicking on modular pipelines #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir <[email protected]>
vladimir-mck
force-pushed
the
bugfix/1462-safari-blank-page
branch
from
5e5b66e
to
6182af7
Compare
tynandebold
approved these changes
Aug 15, 2023
ravi-kumar-pilla
approved these changes
Aug 15, 2023
ravi-kumar-pilla
previously requested changes
Aug 15, 2023
RELEASE.md
Outdated
| @@ -17,6 +18,7 @@ Please follow the established format: | |||
| - Fix broken SVG/PNG exports in light theme. (#1463) | |||
| - Fix dataset and global toolbar error with standalone React component (#1351) | |||
| - Fix `ImportError` as kedro-datasets is now lazily loaded (#1481). | |||
| - Fix the issue of encountering a blank page in Safari when interacting with the modular pipeline. (#1462) | |||
There was a problem hiding this comment.
- Fix the issue of encountering a blank page in Safari when interacting with the modular pipeline. (Fix Safari blank page when clicking on modular pipelines #1488)
There was a problem hiding this comment.
The # number in the bracket should be the PR number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves 1462
Development notes
This issue specifically happens on Safari when interacting with modular pipelines in the sidebar or flowchart. The problem seems to arise during edge redraws. For some reason Safari has several
undefinedvalues in the edges array so I filtered them out when creating new edges.This is the error Safari throws:
And this is the error when I manually catch it in a try / catch block
QA notes
Checklist
RELEASE.mdfile