Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heap parameter to docs script for analytics #1594

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

stichbury
Copy link
Contributor

@stichbury stichbury commented Oct 20, 2023

Description

My attempt to set up Heap. Needs to be verified by someone who understands what they're doing.

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Jo Stichbury <[email protected]>
@stichbury
Copy link
Contributor Author

@astrojuanlu @tynandebold Please can I check on the progress of this in my absence, if any?

@tynandebold
Copy link
Member

No progress from me. I've just added it to our new sprint, so we're tracking it now and will get to it soon.

Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as it should be for me. I noted in a comment we're not switching between dev and prod environments, and I don't think we need to.

Here are the events coming through:

Screenshot 2023-11-01 at 15 34 06

docs/source/_templates/layout.html Show resolved Hide resolved
@stichbury stichbury merged commit 7d81aff into main Nov 1, 2023
5 checks passed
@stichbury stichbury deleted the add-heap-to-docs branch November 1, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants