Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "-p" cli option to match kedro pipeline options #1961

Merged
merged 5 commits into from
Jul 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Working on your first pull request? You can learn how from these resources:

- Fork the project
- Develop your contribution in a new branch and open a PR against the `main` branch
- Make sure the CI builds are green (have a look at the section [Running checks locally](#running-checks-locally) below)
- Make sure the CI builds are green (have a look at the section [Running checks locally](#testing-guidelines) below)
- Update the PR according to the reviewer's comments

# Contribution guidelines
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ Options:

--load-file FILE Path to load Kedro-Viz data from a directory
--save-file FILE Path to save Kedro-Viz data to a directory
--pipeline TEXT Name of the registered pipeline to visualise. If not
-p, --pipeline TEXT Name of the registered pipeline to visualise. If not
set, the default pipeline is visualised

-e, --env TEXT Kedro configuration environment. If not specified,
Expand Down
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Please follow the established format:

- Relax `packaging` pin in requirements. (#1947)
- Add favicon to kedro-viz documentation. (#1959)
- Add "-p" flag to kedro-viz to match kedro run. (#1960)
- Fix bug related to nested namespace pipelines. (#1897)
- Migrate from `toposort` to `graphlib`. (#1942)

Expand Down
32 changes: 32 additions & 0 deletions package/tests/test_launchers/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,38 @@ def mock_project_path(mocker):
"extra_params": {"extra_param": "param"},
},
),
(
[
"viz",
"run",
"--host",
"8.8.8.8",
"--port",
"4142",
"--no-browser",
"--save-file",
"save_dir",
"-p",
"data_science",
"-e",
"local",
"--params",
"extra_param=param",
],
{
"host": "8.8.8.8",
"port": 4142,
"load_file": None,
"save_file": "save_dir",
"pipeline_name": "data_science",
"env": "local",
"project_path": "testPath",
"autoreload": False,
"include_hooks": False,
"package_name": None,
"extra_params": {"extra_param": "param"},
},
),
(
["viz", "run", "--include-hooks"],
{
Expand Down
Loading