Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing run command in metadata panel for task nodes #2055

Merged
merged 9 commits into from
Aug 22, 2024
Merged

Fix missing run command in metadata panel for task nodes #2055

merged 9 commits into from
Aug 22, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Aug 22, 2024 •
edited
Loading

Description

Resolves #2056

Development notes

  • Update set_run_command to use KedroNode name property for constructing run_command string

QA notes

  • All tests should pass
  • Copy and paste the run commands generated and kedro run should work as expected

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix missing run commands for TaskNodeMetadata Fix missing run command in metadata panel for task nodes Aug 22, 2024
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review August 22, 2024 16:20
@ravi-kumar-pilla ravi-kumar-pilla requested review from Huongg and removed request for astrojuanlu August 22, 2024 16:20
Huongg
Huongg approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @ravi-kumar-pilla , working fine for me

@ravi-kumar-pilla ravi-kumar-pilla merged commit b6abe7c into main Aug 22, 2024
40 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/run-command branch August 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitu5 jitu5 jitu5 approved these changes

@Huongg Huongg Huongg approved these changes

@rashidakanchwala rashidakanchwala Awaiting requested review from rashidakanchwala rashidakanchwala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run command for TaskNode not consistent with Kedro
3 participants
@ravi-kumar-pilla @Huongg @jitu5