Make credentials loading consistent between `KedroContext._get_catalo…

…g()` and catalog CLI (#4165) * Use _get_config_credentials() in catalog CLI Update RELEASE.md Signed-off-by: Miguel Rodriguez Gutierrez <[email protected]> * fix tests Signed-off-by: Miguel Rodriguez Gutierrez <[email protected]> * fix test Signed-off-by: Miguel Rodriguez Gutierrez <[email protected]> --------- Signed-off-by: Miguel Rodriguez Gutierrez <[email protected]>
kedro-org · Sep 20, 2024 · 13ff99e · 13ff99e
1 parent 6bf29f9
commit 13ff99e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/RELEASE.md b/RELEASE.md
@@ -9,6 +9,8 @@
 ## Bug fixes and other changes
 * Fixed bug where using dataset factories breaks with `ThreadRunner`.
 * Fixed template projects example tests.
+* Made credentials loading consistent between `KedroContext._get_catalog()` and `resolve_patterns` so that both us
+e `_get_config_credentials()`
 
 ## Breaking changes to the API
 * Removed `ShelveStore` to address a security vulnerability.
@@ -21,6 +23,7 @@
 * [Puneet](https://github.com/puneeter)
 * [ethanknights](https://github.com/ethanknights)
 * [Manezki](https://github.com/Manezki)
+* [MigQ2](https://github.com/MigQ2)
 
 # Release 0.19.8
 

diff --git a/kedro/framework/cli/catalog.py b/kedro/framework/cli/catalog.py
@@ -227,7 +227,7 @@ def resolve_patterns(metadata: ProjectMetadata, env: str) -> None:
     context = session.load_context()
 
     catalog_config = context.config_loader["catalog"]
-    credentials_config = context.config_loader.get("credentials", None)
+    credentials_config = context._get_config_credentials()
     data_catalog = DataCatalog.from_config(
         catalog=catalog_config, credentials=credentials_config
     )

diff --git a/tests/framework/cli/test_catalog.py b/tests/framework/cli/test_catalog.py
@@ -543,6 +543,7 @@ def test_catalog_resolve(
             "catalog": fake_catalog_config,
             "credentials": fake_credentials_config,
         }
+        mocked_context._get_config_credentials.return_value = fake_credentials_config
         mocked_context.catalog = DataCatalog.from_config(
             catalog=fake_catalog_config, credentials=fake_credentials_config
         )