Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump s3fs version number #1995

Closed
datajoely opened this issue Nov 1, 2022 · 4 comments
Closed

Bump s3fs version number #1995

datajoely opened this issue Nov 1, 2022 · 4 comments
Labels
Component: Testing Issue/PR that addresses tests Issue: Feature Request New feature or improvement to existing feature

Comments

@datajoely
Copy link
Contributor

datajoely commented Nov 1, 2022 •
edited by merelcht
Loading

Description

Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..."

Our current setup.py has the following restriction S3FS = "s3fs>=0.3.0, <0.5"

s3fs has been on calendar versioning since April 2021 so we're quite out of date.

Implementation

  • Move to the same calendar versioning scheme we apply to related fsspec project.
  • Fix tests using moto or aiobotocore
@datajoely datajoely added the Issue: Feature Request New feature or improvement to existing feature label Nov 1, 2022
@noklam noklam mentioned this issue Nov 14, 2022
Closed
5 tasks
@noklam
Copy link
Contributor

noklam commented Nov 14, 2022 •
edited
Loading

See #2017 for more details. This may not be trivial as bumping s3fs immediately cause a lot of tests fails. I suspect this is a pure test issue (Kedro will still work, but the tests are not working because of moto or aiobotocore). Will confirm this before backlog grooming.

Estimate: 5/8

@AhdraMeraliQB AhdraMeraliQB added the Component: Testing Issue/PR that addresses tests label Jan 26, 2023
@merelcht merelcht added this to the Redesign Catalog and Datasets milestone Feb 6, 2023
@noklam noklam mentioned this issue Aug 8, 2023
Merged
5 tasks
@noklam
Copy link
Contributor

noklam commented Aug 8, 2023 •
edited
Loading

@datajoely There is some hope that we can tackle it easily with newer version of moto without any change in code.

@astrojuanlu
Copy link
Member

xref kedro-org/kedro-plugins#337, which has an open PR kedro-org/kedro-plugins#348

@merelcht
Copy link
Member

this was completed in kedro-org/kedro-plugins#463 and #3405

@merelcht merelcht removed this from the Redesign the API for IO (catalog) milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Testing Issue/PR that addresses tests Issue: Feature Request New feature or improvement to existing feature
Projects
Kedro Framework
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump s3fs version kedro-org/kedro
5 participants
@astrojuanlu @noklam @datajoely @merelcht @AhdraMeraliQB