Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kedro-datasets to 2.0.0 #3405

Merged
merged 10 commits into from
Dec 12, 2023
Merged

Bump kedro-datasets to 2.0.0 #3405

merged 10 commits into from
Dec 12, 2023

Conversation

merelcht
Copy link
Member

Description

Bump kedro-datasets to the latest 2.0.0 release.

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Merel Theisen <[email protected]>
@astrojuanlu

This comment was marked as resolved.

@astrojuanlu
Copy link
Member

"s3fs>=0.3.0, <0.5", # Needs to be at least 0.3.0 to make use of `cachable` attribute on S3FileSystem.

Guessing that we can remove s3fs from our test requirements?

@merelcht
Copy link
Member Author

"s3fs>=0.3.0, <0.5", # Needs to be at least 0.3.0 to make use of `cachable` attribute on S3FileSystem.

Guessing that we can remove s3fs from our test requirements?

No this is needed for testing cloud interactions via fsspec.

It looks like the docs are still the issue...

@astrojuanlu

This comment was marked as resolved.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
@astrojuanlu

This comment was marked as outdated.

@astrojuanlu
Copy link
Member

It's because of conflicting dependencies. However, maybe we don't need kedro-datasets anymore to build the docs...!

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@astrojuanlu
Copy link
Member

RTD build times cut in half ✌🏽

Signed-off-by: Merel Theisen <[email protected]>
@merelcht merelcht self-assigned this Dec 11, 2023
@merelcht merelcht marked this pull request as ready for review December 11, 2023 18:48
@merelcht merelcht requested review from lrcouto, SajidAlamQB, AhdraMeraliQB and ankatiyar and removed request for stichbury and yetudada December 11, 2023 18:49
@merelcht merelcht enabled auto-merge (squash) December 11, 2023 18:49
@merelcht merelcht merged commit dc72aa1 into develop Dec 12, 2023
36 checks passed
@merelcht merelcht deleted the use-datasets-2.0.0 branch December 12, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants