Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #1432

Merged
merged 14 commits into from
Apr 12, 2022
Merged

Fix unit tests #1432

merged 14 commits into from
Apr 12, 2022

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Apr 12, 2022

Description

#1412

Development notes

This issue is caused by updating moto which I'd experienced earlier on when adding support for Python 3.10 (see point 1 in the development notes).

moto was bumped in the release process: https://github.com/kedro-org/kedro/pull/1398/files, but not necessarily because it was a change required for any functionality.

Things that fix this issue:

  1. Revert the bumping of moto
  2. Run all tests sequentially ⚠️ This will add significant build time to all builds
  3. Run most tests in parallel and only the test_partitioned_dataset.py and test_incremental_dataset.py sequentially. ⚠️ If we do this we won't be able to run the code coverage check as part of the build.

I went for option 1.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@merelcht merelcht requested a review from idanov as a code owner April 12, 2022 13:03
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing our CI🎉

Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for investigating this! 🎉

@merelcht merelcht linked an issue Apr 12, 2022 that may be closed by this pull request
Signed-off-by: Merel Theisen <[email protected]>
@merelcht merelcht requested a review from yetudada as a code owner April 12, 2022 13:35
@merelcht merelcht merged commit 30f4ccd into main Apr 12, 2022
@merelcht merelcht deleted the fix/unit-tests branch April 12, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing unit tests
3 participants