Rewriting the IPython test #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: Nok <[email protected]>
merelcht
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
The tests are so much cleaner and easier to follow now! Great work on refactoring them ⭐
_ProjectPipelines is supposed to be lazy-loaded, but I found out that this line of code triggers the _load_data twice for some reason. Need more investigation.
Did you already found out what's happening with the above or do we need a follow up issue for that?
| PROJECT_NAME = "fake_project_name" | ||
| PROJECT_VERSION = "0.1" | ||
| @pytest.fixture(autouse=True) | ||
| def fake_metadata(tmp_path): |
There was a problem hiding this comment.
Nice cleanup here in making this a fixture 🧹
AhdraMeraliQB
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nok Chan [email protected]
Description
Fix #1839
Development notes
The plan is to break down
TestLoadKedroObjectsinto proper unit tests. the original tests are testing many things at the same time and arguably duplicated. The e2e behaviour is tested inbehavealready, so this test should really just focus on one thing at a time. This can reduce the mocking a little bit (a few mocking are still needed), but they are now easier to reason.Main Changes:
IPythonwhen possible, replace with theipythonfixture insteadpipelineare wrongpipelinesobject instead of_ProjectPipelines, previously the tests will pass/fail sometimes because of the order of instantiation of theglobalormockingsometimes flipped.Notes:
kedro/kedro/framework/session/session.py
Lines 258 to 260 in 82d69f4
_ProjectPipelinesis supposed to be lazy-loaded, but I found out that this line of code triggers the_load_datatwice for some reason. Need more investigation.Checklist
RELEASE.mdfile