-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate kedro.extras.datasets
and add top-level docs for kedro_datasets
#2546
Conversation
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Fix gh-1501. Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
73921f8
to
698164e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do the kedro-datasets
docs get build without the script? They're not part of the repo so how can sphinx build them?
.. automodule:: kedro_datasets | ||
|
||
.. rubric:: Classes | ||
|
||
.. autosummary:: | ||
:toctree: | ||
:template: autosummary/class.rst | ||
|
||
kedro_datasets.api.APIDataSet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@merelcht here's the magic. autodoc
and sphinx.ext.autosummary
only need to be able to import the objects, they don't even have to be downloaded physically!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you need to have kedro-datasets
installed? And what if you have an older version, would it then build old docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, it will load whatever version is installed. Since the docs
extras-requires is getting installed, kedro-datasets
and all its dependencies were already there:
Lines 36 to 37 in a95ce7a
build-docs: | |
pip install -e ".[docs]" |
Line 109 in a95ce7a
"kedro-datasets[api,biosequence,dask,geopandas,matplotlib,holoviews,networkx,pandas,pillow,polars,video,plotly,redis,spark,svmlight,yaml]==1.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, so I guess in that case we need to make sure to bump the pin here whenever we do a kedro-datasets
release to make sure docs are the most recent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added checking to bump the kedro-datasets
doc requirements as a step in the release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thank you 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add this to the release notes as well so we remember when we added the deprecation warnings.
Signed-off-by: Merel Theisen <[email protected]>
I see you went ahead and added it, thanks @merelcht 🙏🏽 |
* Deprecate `kedro.extras.datasets` and add top-level docs for `kedro_datasets` (#2546) Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Delete reference to removed kedro.extras subpackages Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> --------- Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Sorry if I missed something, but shouldn't to: Currently, the DeprecationWarning will be fired whenever using a custom class string. |
Hey @zedrdave , possibly - could you open a new issue so it has more visibility? |
Description
Fix gh-1501.
kedro/extras/datasets/README.md
, visible on GitHub (link):kedro/extras/datasets/__init__.py
, visible in the docs:DeprecationWarning
wheneverkedro.extras.datasets
is imported:kedro.extras.datasets
from thekedro.extras
toctree (not from the navigation bar because that's not possible - an alternative is to declare it as:orphan:
)kedro_datasets
+ replace misleadingkedro.datasets
references that didn't exist + simplify the documentation builds by removing the special script!Development notes
The special handling of
kedro_datasets
was introduced in gh-2006.Checklist
RELEASE.md
file