-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GitPod works #2688
Make GitPod works #2688
Conversation
Signed-off-by: Nok <[email protected]>
@astrojuanlu I removed some of the setup and make it simpler. The current setup simply doesn't work any more as we are not running in the pre-build mode. Do you have any idea to make the current setup to a Docker setup? This PR would at least make sure |
|
👀 Let me have a look |
|
Do we really need
I think that's fine. |
They're needed to build the docs.
I just tested it and worked fine for me in the terminal 🤔 Could you share a screenshot? |
It does work in the terminal. I don't know what've I done last week 😅 https://medium.com/@pidugusundeep5/installing-packages-with-apt-get-on-gitpod-a70f0c6b1cf4 This also convince me that sudo is only possible with Docker |
|
Building a complete version of the docs without warnings requires Line 107 in fd8162d
That doesn't mean that the Gitpod image should install all of them (after all, |
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
This is the closest I can get now, it failed midway with some mermaid error. With the full image the startup time is also longer without pre-built.
|
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Guessing you didn't want to close this? 😄 |
@astrojuanlu Ah, accidentally used the keywords |
Signed-off-by: Nok <[email protected]>
@astrojuanlu It is working now when I start a new Gitpod and do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nitpick!
Signed-off-by: Nok <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried make build-docs
and make lint
and it's working!
* update base image Signed-off-by: Nok <[email protected]> * update gitpod image and apt-get Signed-off-by: Nok <[email protected]> * update docker Signed-off-by: Nok <[email protected]> --------- Signed-off-by: Nok <[email protected]> Signed-off-by: debugger24 <[email protected]>
* FIX: Typo in cli help Signed-off-by: debugger24 <[email protected]> * Make GitPod works (#2688) * update base image Signed-off-by: Nok <[email protected]> * update gitpod image and apt-get Signed-off-by: Nok <[email protected]> * update docker Signed-off-by: Nok <[email protected]> --------- Signed-off-by: Nok <[email protected]> Signed-off-by: debugger24 <[email protected]> * Remove `DeprecatedClassMeta` in favor of `getattr` (#2724) * Complete build requirements Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Add timeout for e2e process waiting Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Remove DeprecatedClassMeta in favor of getattr Fix kedro-org/kedro-starters#137 Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Ignore deprecation warnings in our own code Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> --------- Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> Co-authored-by: Juan Luis Cano Rodríguez <[email protected]> Co-authored-by: Deepyaman Datta <[email protected]> Signed-off-by: debugger24 <[email protected]> --------- Signed-off-by: debugger24 <[email protected]> Signed-off-by: Nok <[email protected]> Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> Co-authored-by: Nok Lam Chan 陳諾林 <[email protected]> Co-authored-by: Deepyaman Datta <[email protected]> Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Description
The whole Gitpod settings is not working at all
pre-commit
is broken, it stuck with some corrupted virtualenv and you need to reinstall it manually.Related to ##2586, but not a complete fix.
Development notes
make lint
work nows againmake build-docs
worksChecklist
RELEASE.md
file