Fix #2498 Adding logging issue 2498

[laizaparizotto]

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

This PR was created in order to add a logging to the file kedro/framework/cli/micropkg.py to help debugging micropackages versioning, after a request on issue #2498.

Development notes

• import logging
• created logger object.
• set the logger warning when micropackage version not found in '{metadata.package_name}.{micropkg_module_path}'.

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change in the RELEASE.md file
• Added tests to cover my changes

[astrojuanlu]

This looks good, thanks @laizaparizotto!

You can include Fix #2498 in the body of the pull request (the title won't work) and make the title a bit more explicit, like "Add logging when computing micropackage version" (in this case, same as the issue).

The continuous integration failures are unrelated, we'll need to wait 1 or 2 days for them to be fixed and then we can merge this PR.

[astrojuanlu]

Actually, there are some linting failures:

kedro/framework/cli/micropkg.py:4:1: F401 'logging' imported but unused
kedro/framework/cli/micropkg.py:596:9: F821 undefined name 'logger'

(you can see those if you click on the "details" button in the failing "lint" checks, or by running make lint locally on your environment)

You'll have to define a logger object, similarly to how it's done in other parts of the codebase.

[laizaparizotto]

Hi @astrojuanlu!

My bad I forgot to add the logger object in the code. Hopefully it will work well now.
Thank you for taking the time to advise.

[astrojuanlu]

No worries!

Notice there are some more linting issues. You can sort some of them out by running make lint locally (this will reformat the code slightly). After doing that, verify make lint again, and fix any remaining issues manually if needed, then commit and push. Repeat until the CircleCI lint-* checks are green.

[merelcht]

Thank you for taking the time to make this contribution @laizaparizotto 🙂 Would you mind adding some more information on the PR description? This helps with reviewing, because it adds some context to the change.

[merelcht]

Hi @laizaparizotto, we'd love to get this contribution in.

1. Could you please add some more details to the PR description, this helps with reviewing as well as future references.
2. Can you also mention this change in the release notes?

Thank you! 🙂

[laizaparizotto]

Hi @laizaparizotto, we'd love to get this contribution in.

1. Could you please add some more details to the PR description, this helps with reviewing as well as future references.
2. Can you also mention this change in the release notes?

Thank you! 🙂

Hi @merelcht. I updated the description. Is it okay or do you recommend a more specific description?
Thank you!

[merelcht]

Hi @merelcht. I updated the description. Is it okay or do you recommend a more specific description? Thank you!

Thanks @laizaparizotto, this looks good 🙂

[SajidAlamQB]

Thank you @laizaparizotto!